linux-kernel - Re: [PATCH] gpu: Consistently use octal not symbolic permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8736yg43nb.fsf@intel.com>
Date:   Fri, 25 May 2018 10:04:40 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Joe Perches <joe@...ches.com>,
        Russell King <linux@...linux.org.uk>,
        Gustavo Padovan <gustavo@...ovan.org>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        Zhenyu Wang <zhenyuw@...ux.intel.com>,
        Zhi Wang <zhi.a.wang@...el.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Rob Clark <robdclark@...il.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David \(ChunMing\) Zhou" <David1.Zhou@....com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Vincent Abriou <vincent.abriou@...com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Roger He <Hongbo.He@....com>, Dave Airlie <airlied@...hat.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     Tomi Valkeinen <tomi.valkeinen@...com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, intel-gvt-dev@...ts.freedesktop.org,
        intel-gfx@...ts.freedesktop.org, linux-arm-msm@...r.kernel.org,
        freedreno@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] gpu: Consistently use octal not symbolic permissions

On Thu, 24 May 2018, Joe Perches <joe@...ches.com> wrote:
> On Fri, 2018-05-25 at 09:41 +0300, Jani Nikula wrote:
>> On Thu, 24 May 2018, Joe Perches <joe@...ches.com> wrote:
>> > There is currently a mixture of octal and symbolic permissions uses
>> > in files in drivers/gpu/drm and one file in drivers/gpu.
>> > 
>> > There are ~270 existing octal uses and ~115 S_<FOO> uses.
>> > 
>> > Convert all the S_<FOO> symbolic permissions to their octal equivalents
>> > as using octal and not symbolic permissions is preferred by many as more
>> > readable.
>> > 
>> > see: https://lkml.org/lkml/2016/8/2/1945
>> > 
>> > Done with automated conversion via:
>> > $ ./scripts/checkpatch.pl -f --types=SYMBOLIC_PERMS --fix-inplace <files...>
>> > 
>> > Miscellanea:
>> > 
>> > o Wrapped modified multi-line calls to a single line where appropriate
>> > o Realign modified multi-line calls to open parenthesis
>> > o drivers/gpu/drm/msm/adreno/a5xx_debugfs.c has a world-writeable
>> >   debug permission for "reset" - perhaps that should be modified
>> > Signed-off-by: Joe Perches <joe@...ches.com>
>> > ---
>> >  drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c        |  2 +-
>> >  drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c             | 98 +++++++++++-----------
>> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c           |  3 +-
>> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c            |  9 +-
>> >  drivers/gpu/drm/armada/armada_debugfs.c            |  4 +-
>> >  drivers/gpu/drm/drm_debugfs.c                      |  6 +-
>> >  drivers/gpu/drm/drm_debugfs_crc.c                  |  4 +-
>> >  drivers/gpu/drm/drm_sysfs.c                        |  2 +-
>> >  drivers/gpu/drm/i915/gvt/firmware.c                |  2 +-
>> >  drivers/gpu/drm/i915/i915_debugfs.c                |  8 +-
>> >  drivers/gpu/drm/i915/i915_perf.c                   |  2 +-
>> >  drivers/gpu/drm/i915/i915_sysfs.c                  | 22 ++---
>> >  drivers/gpu/drm/i915/intel_pipe_crc.c              |  2 +-
>> 
>> Please send at least i915 changes separately. There's zero reason to
>> make our lives harder for this change.
>
> The idea is to avoid unnecessary multiple patches for
> individual trees.

You're changing like a dozen trees. And apparently maintainers of
different trees also have different opinions on whether this is a good
idea or not. Mass changes like this go nowhere, and if they do, will
cause unnecessary conflicts that could have been trivially avoided.

BR,
Jani.

> But you could do that via something like:
>
> $ git am --include='drivers/gpu/drm/i915/*' <patch>
>
> cheers, Joe
>

-- 
Jani Nikula, Intel Open Source Graphics Center