linux-kernel - Re: [PATCH] usb: dwc3: qcom: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 16:00:17 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Manu Gautam <mgautam@...eaurora.org>,
        linux-usb@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc3: qcom: mark PM functions as __maybe_unused

Hi,

On Fri, May 25, 2018 at 9:06 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The #ifdef guards around these are wrong, resulting in warnings
> in certain configurations:
>
> drivers/usb/dwc3/dwc3-qcom.c:244:12: error: 'dwc3_qcom_resume' defined but not used [-Werror=unused-function]
>  static int dwc3_qcom_resume(struct dwc3_qcom *qcom)
>             ^~~~~~~~~~~~~~~~
> drivers/usb/dwc3/dwc3-qcom.c:223:12: error: 'dwc3_qcom_suspend' defined but not used [-Werror=unused-function]
>  static int dwc3_qcom_suspend(struct dwc3_qcom *qcom)
>
> This replaces the guards with __maybe_unused annotations to shut up
> the warnings and give better compile time coverage.
>
> Fixes: a4333c3a6ba9 ("usb: dwc3: Add Qualcomm DWC3 glue driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/usb/dwc3/dwc3-qcom.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

FWIW:

Reviewed-by: Douglas Anderson <dianders@...omium.org>