linux-kernel - Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 17:01:36 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Steve Wise <swise@...ngridcomputing.com>,
        Steve Wise <swise@...lsio.com>,
        Doug Ledford <dledford@...hat.com>,
        Yuval Shaia <yuval.shaia@...cle.com>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Greg Thelen <gthelen@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iw_cxgb4: add INFINIBAND_ADDR_TRANS dependency

On Thu, May 31, 2018 at 12:40:54AM +0200, Arnd Bergmann wrote:
> > On 5/30/2018 5:25 PM, Jason Gunthorpe wrote:
> >> On Wed, May 30, 2018 at 05:10:35PM -0500, Steve Wise wrote:
> >>>
> >>> On 5/30/2018 5:04 PM, Jason Gunthorpe wrote:
> >>>> On Wed, May 30, 2018 at 11:58:18PM +0200, Arnd Bergmann wrote:
> >>>>> The newly added fill_res_ep_entry function fails to link if
> >>>>> CONFIG_INFINIBAND_ADDR_TRANS is not set:
> >>>>>
> >>>>> drivers/infiniband/hw/cxgb4/restrack.o: In function `fill_res_ep_entry':
> >>>>> restrack.c:(.text+0x3cc): undefined reference to `rdma_res_to_id'
> >>>>> restrack.c:(.text+0x3d0): undefined reference to `rdma_iw_cm_id'
> >>>>>
> >>>>> This adds a Kconfig dependency for the driver.
> >>>>>
> >>>>> Fixes: 116aeb887371 ("iw_cxgb4: provide detailed provider-specific CM_ID information")
> >>>>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >>>>>  drivers/infiniband/hw/cxgb4/Kconfig | 1 +
> >>>>>  1 file changed, 1 insertion(+)
> >>>> Oh, I think we need to solve this with maybe a header fill null stub
> >>>> instead..
> >>>>
> >>>> We don't want to disable drivers just because a user interface is
> >>>> disabled.
> >>>>
> >>> Why does CONFIG_INFINIBAND_ADDR_TRANS disable building rdma_cm.ko? That
> >>> is not correct.
> >> That seems like a reasonable thing to do..
> > rdma_ucm.ko is for usermode users, rdma_cm.ko is for kernel users, and
> > is required for iwarp drivers.  It seems rdma_cm.ko is not being
> > compiled if ADDR_TRANS is not set.

I think the intention was to completely disable rdma-cm, including all
support for rx'ing remote packets? Greg?

If this is required for iwarp then Arnd's patch is probably the right
way to go..

Jason