linux-kernel - Re: [virtio-dev] [PATCH] virtio: update the comments for transport features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180601105214.GA9250@debian>
Date:   Fri, 1 Jun 2018 18:52:14 +0800
From:   Tiwei Bie <tiwei.bie@...el.com>
To:     Cornelia Huck <cohuck@...hat.com>
Cc:     mst@...hat.com, jasowang@...hat.com, stefanha@...hat.com,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, virtio-dev@...ts.oasis-open.org
Subject: Re: [virtio-dev] [PATCH] virtio: update the comments for transport
 features

On Fri, Jun 01, 2018 at 12:45:52PM +0200, Cornelia Huck wrote:
> On Fri,  1 Jun 2018 18:22:17 +0800
> Tiwei Bie <tiwei.bie@...el.com> wrote:
> 
> > Suggested-by: Michael S. Tsirkin <mst@...hat.com>
> > Signed-off-by: Tiwei Bie <tiwei.bie@...el.com>
> > ---
> > This patch is generated on top of below patch:
> > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html
> > 
> >  include/uapi/linux/virtio_config.h | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > 
> > diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
> > index b7c1f4e7d59e..479affd903e9 100644
> > --- a/include/uapi/linux/virtio_config.h
> > +++ b/include/uapi/linux/virtio_config.h
> > @@ -45,9 +45,12 @@
> >  /* We've given up on this device. */
> >  #define VIRTIO_CONFIG_S_FAILED		0x80
> >  
> > -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the
> > - * transport being used (eg. virtio_ring), the rest are per-device feature
> > - * bits. */
> > +/*
> > + * Some virtio feature bits (currently bits VIRTIO_TRANSPORT_F_START
> > + * through VIRTIO_TRANSPORT_F_END) are reserved for the transport being
> 
> It will always be bits up to VIRTIO_TRANSPORT_F_END, no? So you can drop
> the "currently"?
> 
> Or reword as "Virtio feature bits VIRTIO_TRANSPORT_F_START through
> VIRTIO_TRANSPORT_F_END are reserved..."?

I will do it. Thanks for the suggestion!

Best regards,
Tiwei Bie