linux-kernel - Re: [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel parameters reusable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <806279a8-1faa-7b86-f761-15eb95b10887@deltatee.com>
Date:   Fri, 1 Jun 2018 09:46:05 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-pci@...r.kernel.org,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Stephen Bates <sbates@...thlin.com>,
        Christoph Hellwig <hch@....de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Frederic Weisbecker <frederic@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH v2 1/3] PCI: Make specifying PCI devices in kernel
 parameters reusable



On 01/06/18 04:39 AM, Andy Shevchenko wrote:
>> -       pci=option[,option...]  [PCI] various PCI subsystem options:
>> +       pci=option[,option...]  [PCI] various PCI subsystem options.
>> +
>> +                               Some options herein operate on a specific device
>> +                               or a set of devices (<pci_dev>). These are
>> +                               specified in one of two formats:
> 
> I would rather to add
> 
>  <pci_dev>
> 
> here in the same way as done for options.
> It would be easy for people to find a referenced paragraph.

Sorry, I don't understand what you are asking. Can you be more specific?

>> +
>> +                               [<domain>:]<bus>:<slot>.<func>
>> +                               pci:<vendor>:<device>[:<subvendor>:<subdevice>]
>> +
>> +                               Note: the first format specifies a PCI
>> +                               bus/slot/function address which may change
>> +                               if new hardware is inserted, if motherboard
>> +                               firmware changes, or due to changes caused
>> +                               by other kernel parameters. The second format
>> +                               selects devices using IDs from the
>> +                               configuration space which may match multiple
>> +                               devices in the system.
> 
>> +static int pci_dev_str_match(struct pci_dev *dev, const char *p,
>> +                            const char **endptr)
> 
> This change I hope has no functional alteration, so, can be split to a
> separate patch.

That's all this patch does... Or do you want be to separate out
documentation from implementation? That just seems a bit excessive to me.

Logan