linux-kernel - RE: Re: [PATCH 1/1] Fix memory leak in kernfs_security_xattr_set and kernfs_security_xattr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180601162913epcms5p7737f5b4376d8865af1eae119aa866550@epcms5p7>
Date:   Fri, 01 Jun 2018 21:59:13 +0530
From:   CHANDAN VN <chandan.vn@...sung.com>
To:     "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>
CC:     Tejun Heo <tj@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "bfields@...ldses.org" <bfields@...ldses.org>,
        "jlayton@...nel.org" <jlayton@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        CPGS <cpgs@...sung.com>,
        Sireesha Talluri <sireesha.t@...sung.com>,
        Chris Wright <chrisw@...s-sol.org>,
        Casey Schaufler <casey@...aufler-ca.com>
Subject: RE: Re: [PATCH 1/1] Fix memory leak in kernfs_security_xattr_set
 and kernfs_security_xattr_set


>> I agree that the fix can be done simply by using "false" for 
>> smack_inode_getsecurity(), but what happens with kernfs_node_setsecdata()
>> and smack_inode_notifysecctx(). kernfs_node_setsecdata() is probably ignorable
>> but smack_inode_notifysecctx() is sending the "ctx" to smack_inode_setsecurity()
>> and since "ctx" would be NULL because we used "false", smack_inode_setsecurity()
>> becomes dummy.
 
>Thank you for pointing this out. You're right, there's more
>at issue here than changing the alloc flag will fix. I think
>that calling smack_inode_getsecurity() from smack_inode_getsecctx()
>is making the code more complicated than it needs to be. I will
>have a patch shortly.

If you think the patch would take time or is complicated, I suggest that the kfree() fix should go
to fix the leaks for now.