[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <152788236518.225090.13622612110912822896@swboyd.mtv.corp.google.com>
Date: Fri, 01 Jun 2018 12:46:05 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Daniel Lezcano <daniel.lezcano@...aro.org>, mturquette@...libre.com
Cc: leo.yan@...aro.org, olof@...om.net, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org
Subject: Re: [PATCH V2] clk/driver/hisi: Consolidate the Kconfig for the CLOCK_STUB
Quoting Daniel Lezcano (2018-05-22 13:45:28)
> The current defconfig is inconsistent as it selects the mailbox and
> the clock for the hi6220 and the hi3660 without having their Kconfigs
> making sure the dependencies are correct. It ends up when selecting
> different versions for the kernel (for example when git bisecting)
> those options disappear and they don't get back, leading to unexpected
> behaviors. In our case, the cpufreq driver does no longer work because
> the clock fails to initialize due to the clock stub and the mailbox
> missing.
>
> In order to have the dependencies correctly set when defaulting, let's
> do the same as commit 3a49afb84ca074e ("clk: enable hi655x common clk
> automatically") where we select automatically the driver when the
> parent driver is selected. With sensible defaults in place, we can leave
> other choices for EXPERT.
>
> Acked-by: Stephen Boyd <sboyd@...nel.org>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
Applied to clk-next
Powered by blists - more mailing lists