linux-kernel - Re: [PATCH V2 net] net: hns: Fix the process of adding broadcast addresses to tcam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180604.173332.935788715931197646.davem@davemloft.net>
Date:   Mon, 04 Jun 2018 17:33:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     salil.mehta@...wei.com
Cc:     yisen.zhuang@...wei.com, lipeng321@...wei.com,
        mehta.salil@...src.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com,
        wangxi11@...wei.com
Subject: Re: [PATCH V2 net] net: hns: Fix the process of adding broadcast
 addresses to tcam

From: Salil Mehta <salil.mehta@...wei.com>
Date: Mon, 4 Jun 2018 17:50:09 +0100

> From: Xi Wang <wangxi11@...wei.com>
> 
> If the multicast mask value in device tree is configured not all
> 0xff, the broadcast mac will be lost from tcam table after the
> execution of command 'ifconfig up'. The address is appended by
> hns_ae_start, but will be clear later by hns_nic_set_rx_mode
> called in dev_open process.
> 
> This patch fixed it by not use the multicast mask when add a
> broadcast address.
> 
> Fixes: b5996f11ea54 ("net: add Hisilicon Network Subsystem basic ethernet support")
> Signed-off-by: Xi Wang <wangxi11@...wei.com>
> Signed-off-by: Peng Li <lipeng321@...wei.com>
> Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> ---
> Patch V2: Fixed comments by David Miller
>    Link: https://lkml.org/lkml/2018/6/4/671
> Patch V1: Initial Submit

Applied and queued up for -stable, thank you.