[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180604173342.0b7a78e6@gandalf.local.home>
Date: Mon, 4 Jun 2018 17:33:42 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Petr Mladek <pmladek@...e.com>
Cc: Maninder Singh <maninder1.s@...sung.com>,
sergey.senozhatsky@...il.com, linux-kernel@...r.kernel.org,
a.sahrawat@...sung.com, pankaj.m@...sung.com, v.narang@...sung.com
Subject: Re: [PATCH 1/2] printk: remove unused flag LOG_NOCONS
On Thu, 31 May 2018 14:16:33 +0200
Petr Mladek <pmladek@...e.com> wrote:
> > enum log_flags {
> > - LOG_NOCONS = 1, /* already flushed, do not print to console */
> > - LOG_NEWLINE = 2, /* text ended with a newline */
> > - LOG_PREFIX = 4, /* text started with a prefix */
> > - LOG_CONT = 8, /* text is a fragment of a continuation line */
> > + LOG_NEWLINE = 1, /* text ended with a newline */
> > + LOG_PREFIX = 2, /* text started with a prefix */
> > + LOG_CONT = 4, /* text is a fragment of a continuation line */
> > };
>
> Please, do not renumber the bits if there is no real need for it.
> The format of the log buffer is read also by external tool like
> "crash". It seems that "crash" ignores these flags but...
Then what's the problem for renumbering? I've renumbered internal flags
before. No one complained about it.
-- Steve
Powered by blists - more mailing lists