linux-kernel - Re: [PATCH] infiniband: fix a possible use-after-free bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpV2PJZUQEcXh=TpHRZzLEqGLDAQ1j1_ibPY_kNfbWoAEQ@mail.gmail.com>
Date:   Mon, 4 Jun 2018 09:30:34 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Gi-Oh Kim <gi-oh.kim@...fitbricks.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Noam Rathaus <noamr@...ondsecurity.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] infiniband: fix a possible use-after-free bug

On Mon, Jun 4, 2018 at 9:23 AM, Gi-Oh Kim <gi-oh.kim@...fitbricks.com> wrote:
> Hi,
>
> Your patch is reasonable to me.
> Can I ask a question for that?
> Could it be solved by asymmetric locking as following?

Maybe, if you are sure taking file->mut is safe in that place.

Can you double check atomic_inc_not_zero(&mc->ctx->ref)?
I am too far away from familiar with infiniband. ;)