linux-kernel - Re: [PATCH] infiniband: fix a possible use-after-free bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180604164249.GA32294@ziepe.ca>
Date:   Mon, 4 Jun 2018 10:42:49 -0600
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     linux-kernel@...r.kernel.org, noamr@...ondsecurity.com,
        Sean Hefty <sean.hefty@...el.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org
Subject: Re: [PATCH] infiniband: fix a possible use-after-free bug

On Fri, Jun 01, 2018 at 11:31:44AM -0700, Cong Wang wrote:
> ucma_process_join() will free the new allocated "mc" struct,
> if there is any error after that, especially the copy_to_user().
> 
> But in parallel, ucma_leave_multicast() could find this "mc"
> through idr_find() before ucma_process_join() frees it, since it
> is already published.
> 
> So "mc" could be used in ucma_leave_multicast() after it is been
> allocated and freed in ucma_process_join(), since we don't refcnt
> it.
> 
> Fix this by separating "publish" from ID allocation, so that we
> can get an ID first and publish it later after copy_to_user().
> 
> Fixes c8f6a362bf3e ("RDMA/cma: Add multicast communication support")
> Reported-by: Noam Rathaus <noamr@...ondsecurity.com>
> Cc: Sean Hefty <sean.hefty@...el.com>
> Cc: Doug Ledford <dledford@...hat.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: linux-rdma@...r.kernel.org
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> ---
>  drivers/infiniband/core/ucma.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Looks good to me, and we already fixed the same sort of bug in the
non-multicast IDs.. Applied to for-next

Jason