linux-kernel - Re: [PATCH v2 2/2] x86: paravirt: make native_save

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26c7fd1c-ab40-368f-c2e3-43a6b45157fd@zytor.com>
Date:   Tue, 5 Jun 2018 10:28:39 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Nick Desaulniers <ndesaulniers@...gle.com>,
        akpm@...ux-foundation.org, ard.biesheuvel@...aro.org,
        aryabinin@...tuozzo.com, akataria@...are.com,
        boris.ostrovsky@...cle.com, brijesh.singh@....com,
        caoj.fnst@...fujitsu.com, gregkh@...uxfoundation.org,
        jan.kiszka@...mens.com, jarkko.sakkinen@...ux.intel.com,
        jgross@...e.com, jpoimboe@...hat.com,
        kirill.shutemov@...ux.intel.com, mingo@...hat.com,
        mjg59@...gle.com, mka@...omium.org, pombredanne@...b.com,
        rostedt@...dmis.org, tglx@...utronix.de, thomas.lendacky@....com,
        tweek@...gle.com
Cc:     linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org,
        x86@...nel.org, virtualization@...ts.linux-foundation.org,
        astrachan@...gle.com, manojgupta@...gle.com, ghackmann@...gle.com,
        sedat.dilek@...il.com, tstellar@...hat.com, keescook@...gle.com,
        yamada.masahiro@...ionext.com, michal.lkml@...kovi.net,
        linux-kbuild@...r.kernel.org, geert@...ux-m68k.org,
        will.deacon@....com, mawilcox@...rosoft.com, arnd@...db.de,
        rientjes@...gle.com
Subject: Re: [PATCH v2 2/2] x86: paravirt: make native_save_fl extern inline

On 06/05/18 10:05, Nick Desaulniers wrote:
> +
> +/*
> + * void native_restore_fl(unsigned long flags)
> + * %rdi: flags
> + */
> +ENTRY(native_restore_fl)
> +	push %_ASM_DI
> +	popf
> +	ret
> +ENDPROC(native_restore_fl)
> +EXPORT_SYMBOL(native_restore_fl)
> 

To work on i386, this would have to be %_ASM_AX in that case.

Something like this added to <asm/asm.h> might be useful; then you can
simply:

	push %_ASM_ARG1

View attachment "0001-x86-asm-add-_ASM_ARG-constants-for-argument-registes.patch" of type "text/x-patch" (2093 bytes)