linux-kernel - Re: [PATCH 01/10] perf tools: Uniquify the event name if there's no other matched event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180607062239.GA18436@krava>
Date:   Thu, 7 Jun 2018 08:22:39 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Agustin Vega-Frias <agustinv@...eaurora.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        Milian Wolff <milian.wolff@...b.com>,
        Andi Kleen <andi@...stfloor.org>,
        Frederic Weisbecker <frederic@...nel.org>
Subject: Re: [PATCH 01/10] perf tools: Uniquify the event name if there's no
 other matched event

On Wed, Jun 06, 2018 at 04:19:02PM -0700, Andi Kleen wrote:
> On Thu, Jun 07, 2018 at 12:15:04AM +0200, Jiri Olsa wrote:
> > Currently by default we try to match the user specified PMU
> > name to all PMU units available and use them to aggregate
> > all matched PMUs event counts into one 'pattern' event.
> > 
> > While this is useful for uncore events, it screws up names
> > for other events, where this is not desirable, like:
> > 
> > Before:
> >   # perf stat -e cp/cpu-cycles/ kill
> 
> I assume you mean cpU/cpu-cycles/
> > 
> >    Performance counter stats for 'kill':
> > 
> >            1,573,757      cp/cpu-cycles/
> > 
> > Keeping the pattern matching logic, but making the name unique
> > in case there's no other match found. That fixes the example
> > above and hopefully does not screw up anything else.
> > 
> > After:
> >   # perf stat -e cp/cpu-cycles/ kill
> > 
> >    Performance counter stats for 'kill':
> > 
> >            1,573,757      cpu/cpu-cycles/
> 
> 
> The output is 100% identical?

nope, the U is actualy missing.. that's the thing, the patern
matching allows you to put 'cp' instead of 'cpu' and the final
output is screwed.. also the metrics won't match the proper event

jirka