linux-kernel - Re: [PATCH] serial: 8250_dw: 8250_dw need to depend on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVZjPRknHY-3b7qr+FgwWmK3g3rCgjjK09Thh2EOLXbcQ@mail.gmail.com>
Date:   Tue, 12 Jun 2018 10:31:51 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_dw: 8250_dw need to depend on COMMON_CLK

On Mon, Jun 11, 2018 at 11:03 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <clabbe@...libre.com> wrote:
> > This patch fix the following build error on M68K:

Not plain m68k, but coldfire only (and MIPS AR7, I guess).

> > drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
> > 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
> > 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
> >
> > So 8250_dw need to depend on COMMON_CLK.
> >
>
> Makes sense.
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Please see "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
(https://lkml.org/lkml/2018/6/11/122).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds