linux-kernel - Re: [PATCH] serial: 8250_dw: 8250_dw need to depend on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeD0KMS1ZGA+kuUUWqAO83tEQW3xh6N_R0o0W8nYsxNsw@mail.gmail.com>
Date:   Tue, 12 Jun 2018 11:36:44 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Corentin Labbe <clabbe@...libre.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_dw: 8250_dw need to depend on COMMON_CLK

On Tue, Jun 12, 2018 at 11:31 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> On Mon, Jun 11, 2018 at 11:03 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
>> On Wed, Jun 6, 2018 at 10:27 PM Corentin Labbe <clabbe@...libre.com> wrote:
>> > This patch fix the following build error on M68K:
>
> Not plain m68k, but coldfire only (and MIPS AR7, I guess).
>
>> > drivers/tty/serial/8250/8250_dw.o: In function `dw8250_set_termios':
>> > 8250_dw.c:(.text+0x50c): undefined reference to `clk_round_rate'
>> > 8250_dw.c:(.text+0x594): undefined reference to `clk_set_rate'
>> >
>> > So 8250_dw need to depend on COMMON_CLK.
>> >
>>
>> Makes sense.
>> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
>
> Please see "[PATCH 0/3] Legacy clock drivers: Normalize clk API"
> (https://lkml.org/lkml/2018/6/11/122).

Indeed, your solution is better.
So, I need to withdraw my tag.

-- 
With Best Regards,
Andy Shevchenko