linux-kernel - Re: [PATCH 4.4 110/268] nvme-pci: Fix nvme queue cleanup if IRQ setup fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1528907855.2289.157.camel@codethink.co.uk>
Date:   Wed, 13 Jun 2018 17:37:35 +0100
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Keith Busch <keith.busch@...el.com>
Cc:     Jianchao Wang <jianchao.w.wang@...cle.com>, stable@...r.kernel.org,
        Sasha Levin <alexander.levin@...rosoft.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4.4 110/268] nvme-pci: Fix nvme queue cleanup if IRQ
 setup fails

On Wed, 2018-06-13 at 10:30 -0600, Keith Busch wrote:
> On Wed, Jun 13, 2018 at 05:14:34PM +0100, Ben Hutchings wrote:
> > On Mon, 2018-05-28 at 12:01 +0200, Greg Kroah-Hartman wrote:
> > >  	result = adapter_alloc_sq(dev, qid, nvmeq);
> > >  	if (result < 0)
> > > @@ -1597,9 +1597,12 @@ static int nvme_create_queue(struct nvme
> > >  	return result;
> > >  
> > >   release_sq:
> > > +	dev->online_queues--;
> > 
> > This addition looks wrong.  dev->online_queues is incremented by
> > nvme_init_queue(), but this function only calls that at a point where
> > it is sure to succeed.  So why would a failure path need to decrement
> > it?
> 
> Thank you very much the catching that. This particular patch is indeed
> not correct without the following:
> 
>   161b8be2bd6ab ("nvme-pci: initialize queue memory before interrupts")

Oh, now I see.  Do you think that commit is suitable for stable
branches?

Ben.

-- 
Ben Hutchings, Software Developer                         Codethink Ltd
https://www.codethink.co.uk/                 Dale House, 35 Dale Street
                                     Manchester, M1 2HF, United Kingdom