linux-kernel - Re: [PATCH] perf intel-pt: Fix packet decoding of CYC packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180613200236.GG2686@kernel.org>
Date:   Wed, 13 Jun 2018 17:02:36 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf intel-pt: Fix packet decoding of CYC packets

Em Thu, Jun 07, 2018 at 02:30:02PM +0300, Adrian Hunter escreveu:
> Use a 64-bit type so that the cycle count is not limited to 32-bits.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> Cc: stable@...r.kernel.org

Thanks, applied.

- Arnaldo

> ---
>  tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c b/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> index ba4c9dd18643..d426761a549d 100644
> --- a/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> +++ b/tools/perf/util/intel-pt-decoder/intel-pt-pkt-decoder.c
> @@ -366,7 +366,7 @@ static int intel_pt_get_cyc(unsigned int byte, const unsigned char *buf,
>  		if (len < offs)
>  			return INTEL_PT_NEED_MORE_BYTES;
>  		byte = buf[offs++];
> -		payload |= (byte >> 1) << shift;
> +		payload |= ((uint64_t)byte >> 1) << shift;
>  	}
>  
>  	packet->type = INTEL_PT_CYC;
> -- 
> 1.9.1