linux-kernel - Re: [PATCH v2 0/3] mtd: rawnand: denali: add new clocks and improve setup_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180614093835.5c3bf426@bbrezillon>
Date:   Thu, 14 Jun 2018 09:38:35 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Richard Weinberger <richard@...ma-star.at>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        Philipp Rosenberger <p.rosenberger@...utronix.de>,
        Rob Herring <robh@...nel.org>,
        DTML <devicetree@...r.kernel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v2 0/3] mtd: rawnand: denali: add new clocks and improve
 setup_data_interface

On Thu, 14 Jun 2018 16:29:59 +0900
Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:

> Hi Richard,
> 
> 2018-06-14 16:25 GMT+09:00 Richard Weinberger <richard@...ma-star.at>:
> > Masahiro,
> >
> > Am Donnerstag, 14. Juni 2018, 07:11:04 CEST schrieb Masahiro Yamada:  
> >>
> >> The ->setup_data_interface() hook needs to know the clock frequency.
> >> In fact, this IP needs three clocks, bus "which clock?" is really
> >> confusing.  (It is not described in the DT-binding at all.)
> >>
> >> This series adds more clocks.  In the new binding, three clocks
> >> are required: core clock, bus interface clock, ECC engine clock.
> >>
> >> This series also takes care of the backward compatibility by
> >> providing hardcoded values in case the new clocks are missing.
> >> So, existing DT should work.
> >>
> >>
> >> Changes in v2:
> >>   - Split patches into sensible chunks
> >>
> >> Masahiro Yamada (3):
> >>   mtd: rawnand: denali_dt: use dev as a shorthand of &pdev->dev
> >>   mtd: rawnand: denali_dt: add more clocks based on IP datasheet
> >>   mtd: rawnand: denali: optimize timing parameters for data interface  
> >
> > This still means that we need to feed at least 2/3 and 3/3 into -stable to
> > unbreak the driver.  
> 
> 
> 3/3 is not mandatory.
> 
> You can only back-port 1/3 and 2/3.

Well, patch 1 is not a fix, can we move it after patch 2 so that only
patch 2 is flagged with the Fixes+Cc-stable tags?

Thanks,

Boris