linux-kernel - Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC check when attaching ubi vol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180614100436.40741c67@bbrezillon>
Date:   Thu, 14 Jun 2018 10:04:36 +0200
From:   Boris Brezillon <boris.brezillon@...tlin.com>
To:     Richard Weinberger <richard@....at>
Cc:     Quentin Schulz <quentin.schulz@...tlin.com>, marek.vasut@...il.com,
        dedekind1@...il.com, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org, thomas.petazzoni@...tlin.com,
        computersforpeace@...il.com, dwmw2@...radead.org
Subject: Re: [PATCH 2/2] ubi: introduce ubi.nocheck parameter to skip CRC
 check when attaching ubi vol

On Thu, 14 Jun 2018 09:29:42 +0200
Richard Weinberger <richard@....at> wrote:

> Quentin,
> 
> Am Montag, 11. Juni 2018, 12:20:37 CEST schrieb Quentin Schulz:
> > If we go for a per-image flag, adding nocheck to the ioctl makes sense,
> > otherwise we have to find a way to select only one or more volumes for
> > which the nocheck flag should be set. That being said, I'm not sure a
> > per-image flag is the way we want to go.
> > 
> > What are your thoughts on this?  
> 
> I like that approach a lot more, please send a patch. :-)

I don't think the approach you're talking about has been mentioned by
Quentin in this email :-). To clarify the discussion, we're talking
about adding a new flag to VTBL entries telling whether the CRC should
be skipped or not.

> Having a volume flag will reduce complexity a lot.

That's my opinion as well.