linux-kernel - Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a20cc6a0c278cc2791c0bdfc30a79b022de396ef.camel@nxp.com>
Date:   Thu, 14 Jun 2018 10:17:20 +0000
From:   Leonard Crestez <leonard.crestez@....com>
To:     Fabio Estevam <fabio.estevam@....com>
CC:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andy Duan <fugang.duan@....com>,
        "A.s. Dong" <aisheng.dong@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "slongerbeam@...il.com" <slongerbeam@...il.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH 1/2] ARM: dts: imx6qdl-sabreauto: Add sensors

On Thu, 2018-06-07 at 14:07 -0300, Fabio Estevam wrote:
> Hi Leonard,
> 
> On Thu, Jun 7, 2018 at 2:00 PM, Leonard Crestez <leonard.crestez@....com> wrote:
> 
> > +
> > +                       isl29023@44 {
> 
> According to Devicetree Specification v0.2 document:
> 
> "The name of a node should be somewhat generic, reflecting the function
> of the device and not its precise programming model."
> 
> So you could write:
> 
> light-sensor@44

Ok, will fix in v2.

Should I also assign a label, like "isl29023: light-sensor@44"? I
couldn't find any recommendation on this.

There are no immediate uses for a label but this practice is very
common. Having labels allows creating minor board variants with reduced
churn in the base dts so it seems good.

--
Regards,
Leonard