linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: add mt6765 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80bca2ae-eb08-3d6c-a863-140107286b2d@gmail.com>
Date:   Fri, 15 Jun 2018 10:54:18 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Mars Cheng <mars.cheng@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     CC Hwang <cc.hwang@...iatek.com>,
        Loda Chou <loda.chou@...iatek.com>,
        Miles Chen <miles.chen@...iatek.com>,
        Jades Shih <jades.shih@...iatek.com>,
        Yingjoe Chen <yingjoe.chen@...iatek.com>,
        My Chuang <my.chuang@...iatek.com>,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        devicetree@...r.kernel.org, wsd_upstream@...iatek.com
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: add mt6765 support



On 13/06/18 00:40, Mars Cheng wrote:
> +
> +	uart0: serial@...02000 {
> +		compatible = "mediatek,mt6765-uart",
> +			     "mediatek,mt6577-uart";
> +		reg = <0 0x11002000 0 0x400>;
> +		interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&uart_clk>;
> +		status = "disabled";
> +	};

You need "baud" and "bus" clock. Also add clock-names please.

> +
> +	uart1: serial@...03000 {
> +		compatible = "mediatek,mt6765-uart",
> +			     "mediatek,mt6577-uart";
> +		reg = <0 0x11003000 0 0x400>;
> +		interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&uart_clk>;
> +		status = "disabled";

Same here obviously.

Regards,
Matthias