linux-kernel - 答复: [PATCH v2] usb: xhci: remove the code build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0184EA26B2509940AA629AE1405DD7F201CE2843@DGGEMA503-MBX.china.huawei.com>
Date:   Sat, 16 Jun 2018 09:08:23 +0000
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        "jonathanh@...dia.com" <jonathanh@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: 答复: [PATCH v2] usb: xhci: remove the code build warning

> On Wed, Jun 06, 2018 at 10:36:59PM +0800, Dongjiu Geng wrote:
> > Initialize the 'err' variate to remove the build warning, the warning
> > is shown as below:
> >
> > drivers/usb/host/xhci-tegra.c: In function 'tegra_xusb_mbox_thread':
> > drivers/usb/host/xhci-tegra.c:552:6: warning: 'err' may be used
> > uninitialized in this function [-Wuninitialized]
> > drivers/usb/host/xhci-tegra.c:482:6: note: 'err' was declared here
> >
> > Signed-off-by: Dongjiu Geng <gengdongjiu@...wei.com>
> > Acked-by: Thierry Reding <treding@...dia.com>
> > ---
> > How to reproduce:
> > 1. make defconfig ARCH=arm
> > 2. make -j100 CROSS_COMPILE=arm-linux-gnueabi- ARCH=arm
> >
> > Then you can see below warnings:
> > drivers/usb/host/xhci-tegra.c: In function 'tegra_xusb_mbox_thread':
> > drivers/usb/host/xhci-tegra.c:552:6: warning: 'err' may be used
> > uninitialized in this function [-Wuninitialized]
> > drivers/usb/host/xhci-tegra.c:482:6: note: 'err' was declared here
> 
> What changed from v1?  Always put that below the --- line.
> 
> Please fix up and resend a v3.


Thanks, I justly add "Acked-by: Thierry Reding <treding@...dia.com>" in the V2 compared with v1
Anyway I will put that below and resend a v3.

> 
> thanks,
> 
> greg k-h