linux-kernel - Re: can we drop the comedi serial2002 drivers from staging?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180616093740.GA9816@kroah.com>
Date:   Sat, 16 Jun 2018 11:37:40 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Ian Abbott <abbotti@....co.uk>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        linux-kernel@...r.kernel.org
Subject: Re: can we drop the comedi serial2002 drivers from staging?

On Sat, Jun 16, 2018 at 11:06:45AM +0200, Christoph Hellwig wrote:
> As far as I can tell there has been no targeted work on the driver
> since merging it at all, and since 2014 even the comedi-wide
> cleanups stopped, laving just drive by tree wide changes since.
> 
> At the same time the driver badly abuses the tty layer and is one
> of only two major abusers of the poll code for in-kernel waits.

Yeah, it's an ugly driver.  It should be rewritten to use the new serdev
api instead of trying to open a tty device node from within the kernel.

I don't object to dropping it.  Ian and Hartley, do you know of any
users of this driver anymore?

thanks,

greg k-h