linux-kernel - Re: [PATCHv3 09/18] atomics/alpha: define atomic64_fetch_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180618160829.5jrscmfkorjxdvod@lakrids.cambridge.arm.com>
Date:   Mon, 18 Jun 2018 17:08:30 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Will Deacon <will.deacon@....com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        boqun.feng@...il.com, mingo@...nel.org,
        Richard Henderson <rth@...ddle.net>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>
Subject: Re: [PATCHv3 09/18] atomics/alpha: define atomic64_fetch_add_unless()

On Mon, Jun 18, 2018 at 04:54:40PM +0100, Will Deacon wrote:
> On Mon, Jun 18, 2018 at 11:19:10AM +0100, Mark Rutland wrote:
> >  /**
> > - * atomic64_add_unless - add unless the number is a given value
> > + * atomic64_fetch_add_unless - add unless the number is a given value
> >   * @v: pointer of type atomic64_t
> >   * @a: the amount to add to v...
> >   * @u: ...unless v is equal to u.
> >   *
> >   * Atomically adds @a to @v, so long as it was not @u.
> > - * Returns true iff @v was not @u.
> > + * Returns the old value of @v.
> >   */
> > -static __inline__ int atomic64_add_unless(atomic64_t *v, long a, long u)
> > +static __inline__ int atomic64_fetch_add_unless(atomic64_t *v, long a, long u)
> 

Whoops; yes.

>From a scan of the series, I messed that up in the instrumentation, too,
but the rest sems fine.

I'll fix those up and push out an updated branch.

Thanks,
Mark.