linux-kernel - Re: [PATCHv3 07/18] atomics: prepare for atomic64_fetch_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180618161054.nez5trvedaz5qk7h@lakrids.cambridge.arm.com>
Date:   Mon, 18 Jun 2018 17:10:55 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     linux-kernel@...r.kernel.org, will.deacon@....com,
        peterz@...radead.org, boqun.feng@...il.com
Cc:     mingo@...nel.org, Arnd Bergmann <arnd@...db.de>,
        Richard Henderson <rth@...ddle.net>,
        Ivan Kokshaysky <ink@...assic.park.msu.ru>,
        Matt Turner <mattst88@...il.com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Russell King <linux@...linux.org.uk>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <albert@...ive.com>
Subject: Re: [PATCHv3 07/18] atomics: prepare for atomic64_fetch_add_unless()

On Mon, Jun 18, 2018 at 11:19:08AM +0100, Mark Rutland wrote:
> Currently architecture must implement atomic_fetch_add_unless(), with
> common code providing atomic_add_unless(). Architectures must also
> implement atmic64_add_unless() directly, with no corresponding
> atomic64_fetch_add_unless().
> 
> This divergenece is unfortunate, and means that the APIs for atomic_t,
> atomic64_t, and atomic_long_t differ.
> 
> In preparation for unifying things, with architectures providing
> atomic64_fetch_add_unless, this patch adds a generic
> atomic64_add_unless() which will use atomic64_fetch_add_unless(). The
> instrumented atomics are updated to take this case into account.

> +#ifdef arch_atomic64_fetch_add_unless
> +#define atomic64_fetch_add_unless atomic64_fetch_add_unless
> +static __always_inline int atomic64_fetch_add_unless(atomic64_t *v, s64 a, s64 u)

Whoops: s/int/s64/ here

I've fixed that up in my branch.

Thanks,
Mark.