linux-kernel - Re: [PATCH] ARC: dts: Remove leading 0x from node unit addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8268db75d4698a4fba9aa11de7e8f6d6f20a0515.camel@perches.com>
Date:   Mon, 18 Jun 2018 13:07:32 -0700
From:   Joe Perches <joe@...ches.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Vineet Gupta <vgupta@...opsys.com>,
        Alexey Brodkin <abrodkin@...opsys.com>,
        Eugeniy Paltsev <Eugeniy.Paltsev@...opsys.com>,
        devicetree@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARC: dts: Remove leading 0x from node unit addresses

On Mon, 2018-06-18 at 21:16 +0200, Krzysztof Kozlowski wrote:
> Remove leading 0x from all node unit addresses with a sed command:
> 
>     sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" arch/arc/boot/dts/*.dts*
> 
> This fixes DTC warnings like:
> 
>     Warning (unit_address_format): /cpu_card/dw-apb-gpio@...000: unit name should not have leading "0x"

Do all of these need fixing?

Aren't there dozens of these in arch/arm and elsewhere too?

$ git grep -i -P "@0x([0-9a-f]+)\s*\{" -- "*.dt*"|cat
arch/arc/boot/dts/abilis_tb10x.dtsi:		spi0: spi@...E010000 {
arch/arc/boot/dts/abilis_tb10x.dtsi:		spi1: spi@...E011000 {
arch/arc/boot/dts/axc001.dtsi:		dw-apb-gpio@...000 {
arch/arc/boot/dts/axc001.dtsi:		debug_uart: dw-apb-uart@...000 {
arch/arc/boot/dts/axc001.dtsi:	mb_intc: dw-apb-ictl@...0012000 {
arch/arc/boot/dts/axc003.dtsi:		dw-apb-gpio@...000 {
arch/arc/boot/dts/axc003.dtsi:		debug_uart: dw-apb-uart@...000 {
arch/arc/boot/dts/axc003.dtsi:	mb_intc: dw-apb-ictl@...0012000 {
arch/arc/boot/dts/axc003_idu.dtsi:		dw-apb-gpio@...000 {
arch/arc/boot/dts/axc003_idu.dtsi:		debug_uart: dw-apb-uart@...000 {
arch/arc/boot/dts/axc003_idu.dtsi:	mb_intc: dw-apb-ictl@...0012000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		ethernet@...8000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		ehci@...0000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		ohci@...0000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		mmc@...5000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		uart@...0000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		uart@...1000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		uart@...2000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		i2c@...d000 {
arch/arc/boot/dts/axs10x_mb.dtsi:		i2c@...f000 {
arch/arc/boot/dts/axs10x_mb.dtsi:			eeprom@...4{
arch/arc/boot/dts/axs10x_mb.dtsi:			eeprom@...7{
arch/arc/boot/dts/vdk_axc003.dtsi:		debug_uart: dw-apb-uart@...000 {
arch/arc/boot/dts/vdk_axc003.dtsi:	mb_intc: dw-apb-ictl@...0012000 {
arch/arc/boot/dts/vdk_axc003_idu.dtsi:		debug_uart: dw-apb-uart@...000 {
arch/arc/boot/dts/vdk_axc003_idu.dtsi:	mb_intc: dw-apb-ictl@...0012000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		ethernet@...8000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		ehci@...0000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		uart@...0000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		uart@...1000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		uart@...2000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:		mmc@...5000 {
arch/arc/boot/dts/vdk_axs10x_mb.dtsi:	uio_ev: uio@...0000000 {
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts:						bootloaderenv@...00000 {
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts:						bootloaderenvred@...40000 {
arch/arm/boot/dts/atlas7.dtsi:			pmipc@...3240000 {
arch/arm/boot/dts/atlas7.dtsi:			gnssmfw@...8100000 {
arch/arm/boot/dts/atlas7.dtsi:			gpum@...3000000 {
arch/arm/boot/dts/atlas7.dtsi:			sdr@...3010000 {
arch/arm/boot/dts/atlas7.dtsi:			memory-controller@...0800000 {
arch/arm/boot/dts/atlas7.dtsi:			retain@...88D0000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@...0000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@...c0000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@...80000 {
arch/arm/boot/dts/dm8148-evm.dts:		partition@...80000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@...0000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@...c0000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@...80000 {
arch/arm/boot/dts/dm8168-evm.dts:		partition@...80000 {
arch/arm/boot/dts/keystone-k2e-netcp.dtsi:		pdsp0@...a10000 {
arch/arm/boot/dts/keystone-k2hk-netcp.dtsi:		pdsp0@...a10000 {
arch/arm/boot/dts/keystone-k2l-netcp.dtsi:		pdsp0@...a10000 {
arch/arm/boot/dts/socfpga.dtsi:		l3regs@...f800000 {
arch/arm/boot/dts/spear300.dtsi:		shirq: interrupt-controller@...0000000 {
arch/arm/boot/dts/spear310.dtsi:		shirq: interrupt-controller@...4000000 {
arch/arm/boot/dts/spear320.dtsi:		shirq: interrupt-controller@...3000000 {
arch/arm64/boot/dts/exynos/exynos5433.dtsi:		sysmmu_scaler_0: sysmmu@...5040000 {
arch/arm64/boot/dts/exynos/exynos5433.dtsi:		sysmmu_scaler_1: sysmmu@...5050000 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@0x0 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@...000000 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@...800000 {
arch/xtensa/boot/dts/xtfpga-flash-128m.dtsi:			partition@...fe0000 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@0x0 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@...00000 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@...00000 {
arch/xtensa/boot/dts/xtfpga-flash-16m.dtsi:			partition@...e0000 {
arch/xtensa/boot/dts/xtfpga-flash-4m.dtsi:			partition@0x0 {
arch/xtensa/boot/dts/xtfpga-flash-4m.dtsi:			partition@...f0000 {