linux-kernel - Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180618201129.GH21724@codeaurora.org>
Date:   Mon, 18 Jun 2018 14:11:29 -0600
From:   Lina Iyer <ilina@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Raju P L S S S N <rplsssn@...eaurora.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        linux-arm-msm@...r.kernel.org,
        "open list:ARM/QUALCOMM SUPPORT" <linux-soc@...r.kernel.org>,
        Rajendra Nayak <rnayak@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Evan Green <evgreen@...omium.org>,
        Matthias Kaehlcke <mka@...omium.org>
Subject: Re: [PATCH v11 04/10] drivers: qcom: rpmh: add RPMH helper functions

On Mon, Jun 18 2018 at 13:54 -0600, Doug Anderson wrote:
>Hi,
>
>On Mon, Jun 18, 2018 at 12:06 PM, Lina Iyer <ilina@...eaurora.org> wrote:
>> On Mon, Jun 18 2018 at 12:33 -0600, Doug Anderson wrote:
>>>
>>> Lina,
>>>
>>> On Mon, Jun 18, 2018 at 9:39 AM, Lina Iyer <ilina@...eaurora.org> wrote:
>>>>>
>>>>> +/**
>>>>>  * struct rsc_drv: the Direct Resource Voter (DRV) of the
>>>>>  * Resource State Coordinator controller (RSC)
>>>>>  *
>>>>> @@ -52,6 +78,7 @@ struct tcs_group {
>>>>>  * @tcs:        TCS groups
>>>>>  * @tcs_in_use: s/w state of the TCS
>>>>>  * @lock:       synchronize state of the controller
>>>>> + * @ctrl:       controller to handle cases like batch requests
>>>>
>>>>
>>>> This is not only for batch requests.
>>>> This is handle to the DRV's client. @client might be a better name than
>>>> @ctrlr.
>>>
>>>
>>> The name "ctrlr" also matches the name of the structure.  Are you
>>> suggesting also renaming "struct rpmh_ctrlr" to "struct rpmh_client",
>>> or you think they should be different names?
>>>
>> Just the name of the variable. I was just a nice to have. I wouldn't
>> block for this though.
>>
>> I also got a couple Bot reported issues on this and the previous
>> revision that I have sent to Raju. He is planning to the post the v12
>> tomorrow his time after fixing them. If you can wait until then, I would
>> recommend picking up the v12 instead of this.
>
>OK, if Raju can post the v12 tomorrow his time then that sounds like a
>great plan to me.  While you're at it, I noticed that checkpatch
>yelled about a few lines that were > 80 characters long for no good
>reason.  Those would be nice to fix too.
>
Yup. He got that too.

-- Lina