linux-kernel - Re: [PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of hardcoded string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcnFbc3SKh-6Ovc4nxNTPLaYU9LeGNz8eCRdJficek5EQ@mail.gmail.com>
Date:   Tue, 19 Jun 2018 23:19:37 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of
 hardcoded string - Style

On Tue, Jun 19, 2018 at 10:56 PM, John Whitmore <johnfwhitmore@...il.com> wrote:
> Changed a number of hard coded function names to use %s and __func__

Oh.

Looking at the code, much better fix would be...

Move IEEE80211_DEBUG() to use netdev_dbg() [dev_dbg() or pr_dbg() as
last resort) and actually drop it completely in favour of the
netdev_dbg() followed by removing __func__ parameter completely from
the messages as DYNAMIC DEBUG will do this if user asks so.

The IEEE80211_DEBUG_DATA() should be just print_hex_dump().

P.S. I would rather NAK this patch because it brings nothing, just a
waste of time for my opinion.

-- 
With Best Regards,
Andy Shevchenko