linux-kernel - Re: [PATCH] tee: replace getnstimeofday64() with ktime_get_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180619142304.GA12933@jax.urgonet>
Date:   Tue, 19 Jun 2018 16:23:05 +0200
From:   Jens Wiklander <jens.wiklander@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     y2038 Mailman List <y2038@...ts.linaro.org>,
        Jerome Forissier <jerome.forissier@...aro.org>,
        Etienne Carriere <etienne.carriere@...aro.org>,
        Joakim Bech <joakim.bech@...aro.org>,
        Volodymyr Babchuk <vlad.babchuk@...il.com>,
        tiger-yu99 <tigeryu99@...mail.com>,
        David Wang <david.wang@....com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tee: replace getnstimeofday64() with
 ktime_get_real_ts64()

On Tue, Jun 19, 2018 at 04:05:38PM +0200, Arnd Bergmann wrote:
> On Tue, Jun 19, 2018 at 3:37 PM, Jens Wiklander
> <jens.wiklander@...aro.org> wrote:
> > On Mon, Jun 18, 2018 at 04:24:56PM +0200, Arnd Bergmann wrote:
> >> The two do the same thing, but we want to have a consistent
> >> naming in the kernel.
> >>
> >> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> >> ---
> >>  drivers/tee/optee/rpc.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/tee/optee/rpc.c b/drivers/tee/optee/rpc.c
> >> index 41aea12e2bcc..b45c73dd37a5 100644
> >> --- a/drivers/tee/optee/rpc.c
> >> +++ b/drivers/tee/optee/rpc.c
> >> @@ -48,7 +48,7 @@ static void handle_rpc_func_cmd_get_time(struct optee_msg_arg *arg)
> >>                       OPTEE_MSG_ATTR_TYPE_VALUE_OUTPUT)
> >>               goto bad;
> >>
> >> -     getnstimeofday64(&ts);
> >> +     ktime_get_real_ts64(&ts);
> >>       arg->params[0].u.value.a = ts.tv_sec;
> >>       arg->params[0].u.value.b = ts.tv_nsec;
> >>
> >> --
> >> 2.9.0
> >>
> >
> > Looks good.
> >
> > Acked-by: Jens Wiklander <jens.wiklander@...aro.org>
> 
> Thanks for the review. Can you pick it up in your tree?

OK, I'll pick it up.

Thanks,
Jens