linux-kernel - Re: [RFC v7 1/1] mconf: global i-search in menu prompts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <01450eac-3c65-efa1-8a9e-aaea98088bac@infradead.org>
Date:   Tue, 19 Jun 2018 10:43:45 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Dirk Gouders <dirk@...ders.net>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Sam Ravnborg <sam@...nborg.org>
Subject: Re: [RFC v7 1/1] mconf: global i-search in menu prompts

On 06/17/2018 05:15 AM, Dirk Gouders wrote:

> Signed-off-by: Dirk Gouders <dirk@...ders.net>
> ---
>  scripts/kconfig/lxdialog/checklist.c |   2 +-
>  scripts/kconfig/lxdialog/dialog.h    |   3 +-
>  scripts/kconfig/lxdialog/inputbox.c  |   2 +-
>  scripts/kconfig/lxdialog/menubox.c   | 181 +++++++++++++++++++++---
>  scripts/kconfig/lxdialog/util.c      |  45 +++++-
>  scripts/kconfig/lxdialog/yesno.c     |   2 +-
>  scripts/kconfig/mconf.c              | 202 +++++++++++++++++++++++++--
>  7 files changed, 398 insertions(+), 39 deletions(-)

Hi Dirk,

A few typos below...


> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 5294ed159b98..e2e6fc973f6f 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -21,6 +21,12 @@
>  #include "lkc.h"
>  #include "lxdialog/dialog.h"
>  
> +extern int focus_on_buttons;
> +extern char isearch_str[];
> +static struct menu **flat_menu; /* serialized menu tree */
> +static int flat_menu_max = 10;
> +static int in_isearch;	      /* Ensure at most one instance of i-search is active */
> +
>  static const char mconf_readme[] =
>  "Overview\n"
>  "--------\n"
> @@ -36,20 +42,74 @@ static const char mconf_readme[] =
>  "while *, M or whitespace inside braces means to build in, build as\n"
>  "a module or to exclude the feature respectively.\n"
>  "\n"
> -"To change any of these features, highlight it with the cursor\n"
> -"keys and press <Y> to build it in, <M> to make it a module or\n"
> +"Operation modes\n"
> +"---------------\n"
> +"Menuconfig operates in two modes, depending on the focus that can be\n"
> +"either on the menu or the buttons below it. The focus is on the\n"
> +"buttons if one button (the selected one) is highlighted, otherwise it\n"
> +"is on the menu.\n"
> +"\n"
> +"To change any of the above features, it has to be navigated to (see\n"
> +"below) so that it is highlited, focus then has to be on the buttons\n"

                         highlighted,

> +"before you press <Y> to build it in, <M> to make it a module or\n"
>  "<N> to remove it.  You may also press the <Space Bar> to cycle\n"
>  "through the available options (i.e. Y->N->M->Y).\n"
>  "\n"
> +"Navigation\n"
> +"----------\n"
> +"The following keys work independent of the current focus:\n"

                            independently

> +"\n"
> +"o vertical arrow keys are used to navigate to menu items\n"
> +"\n"
> +"o horizontal arrow keys put the focus on the buttons and cycle\n"
> +"  between the buttons.\n"
> +"\n"
> +"o <PAGE UP> and <PAGE DOWN> scroll invisible items into view.\n"
> +"\n"
> +"o <ENTER> visits a submenu\n"
> +"  Submenus are designated by \"--->\", empty ones by \"----\".\n"
> +"\n"
> +"o <ESC><ESC> leaves a submenu or (in the main menu) exits menuconfig\n"
> +"  and clears the current i-search string."
> +"\n"
> +"o <TAB> is reserved to toggle the focus between menu and buttons\n"
> +"\n"
> +"When menuconfig starts, the focus is on the menu and i-search mode\n"
> +"is active.  I-search performs continuous cyclic searches for an entered\n"
> +"string in the prompt texts of the whole menu tree.\n"
> +"\n"
> +"Subsequent characters can be entered to build a search-string the\n"
> +"menu items are searched for and each time a character is added the\n"
> +"current string is searched for starting from the current position in\n"
> +"the menu tree.  If a match is found it is immediately navigated to.\n"
> +"\n"
> +"Keys with a special meaning are:\n"
> +"\n"
> +"o <BACKSPACE> removes the last character from the current search string\n"
> +"\n"
> +"o <DEL> clears the search string\n"
> +"\n"
> +"o <\\> (backslash) can be used to find further matches of a string\n"
> +"\n"
> +"When the focus is on the buttons the following keys can be used:\n"
> +"\n"
> +"o <x> can be used for exit identical to <ESC><ESC>\n"
> +"\n"
> +"o <y>, <n>, <m> or <SPACE> change the selected item\n"
> +"\n"
> +"o <+> and <-> keys navigate menu items identical to vertical arrow\n"
> +"  keys\n"
> +"\n"
> +"o <h> or <?> display help messages\n"
> +"\n"
> +"o <z> toggles the display of hidden options\n"

Ah, there it is!  Thanks.

> +"\n"
>  "Some additional keyboard hints:\n"
>  "\n"
>  "Menus\n"
>  "----------\n"
> -"o  Use the Up/Down arrow keys (cursor keys) to highlight the item you\n"
> -"   wish to change or the submenu you wish to select and press <Enter>.\n"
> -"   Submenus are designated by \"--->\", empty ones by \"----\".\n"
> -"\n"
> -"   Shortcut: Press the option's highlighted letter (hotkey).\n"
> +"o  Hotkeys (available with focus on buttons): Press the target option's\n"
> +"             highlighted letter (hotkey).\n"
>  "             Pressing a hotkey more than once will sequence\n"
>  "             through all visible items which use that hotkey.\n"
>  "\n"


thanks,
-- 
~Randy