linux-kernel - Re: [PATCH v4 2/9] Uprobe: Change set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 20 Jun 2018 13:32:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Cc:     kbuild-all@...org, oleg@...hat.com, srikar@...ux.vnet.ibm.com,
        rostedt@...dmis.org, mhiramat@...nel.org, peterz@...radead.org,
        mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, linux-kernel@...r.kernel.org, corbet@....net,
        linux-doc@...r.kernel.org, ananth@...ux.vnet.ibm.com,
        alexis.berlemont@...il.com, naveen.n.rao@...ux.vnet.ibm.com,
        Ravi Bangoria <ravi.bangoria@...ux.ibm.com>
Subject: Re: [PATCH v4 2/9] Uprobe: Change set_swbp definition

Hi Ravi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[also build test ERROR on v4.18-rc1 next-20180619]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Ravi-Bangoria/Uprobes-Support-SDT-markers-having-reference-count-semaphore/20180620-120240
config: arm-exynos_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

   In file included from arch/arm/include/asm/bug.h:7:0,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:12,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/arm/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:81,
                    from include/linux/spinlock.h:51,
                    from include/linux/wait.h:9,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from include/linux/highmem.h:5,
                    from arch/arm/probes/uprobes/core.c:12:
   arch/arm/probes/uprobes/core.c: In function 'set_swbp':
>> arch/arm/probes/uprobes/core.c:36:32: error: dereferencing pointer to incomplete type 'struct uprobe'
         __opcode_to_mem_arm(uprobe->arch.bpinsn));
                                   ^
   arch/arm/include/asm/opcodes.h:95:40: note: in definition of macro '___opcode_identity32'
    #define ___opcode_identity32(x) ((u32)(x))
                                           ^
>> arch/arm/probes/uprobes/core.c:36:6: note: in expansion of macro '__opcode_to_mem_arm'
         __opcode_to_mem_arm(uprobe->arch.bpinsn));
         ^~~~~~~~~~~~~~~~~~~
>> arch/arm/probes/uprobes/core.c:37:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +36 arch/arm/probes/uprobes/core.c

  > 12	#include <linux/highmem.h>
    13	#include <linux/sched.h>
    14	#include <linux/uprobes.h>
    15	#include <linux/notifier.h>
    16	
    17	#include <asm/opcodes.h>
    18	#include <asm/traps.h>
    19	
    20	#include "../decode.h"
    21	#include "../decode-arm.h"
    22	#include "core.h"
    23	
    24	#define UPROBE_TRAP_NR	UINT_MAX
    25	
    26	bool is_swbp_insn(uprobe_opcode_t *insn)
    27	{
    28		return (__mem_to_opcode_arm(*insn) & 0x0fffffff) ==
    29			(UPROBE_SWBP_ARM_INSN & 0x0fffffff);
    30	}
    31	
    32	int set_swbp(struct uprobe *uprobe, struct mm_struct *mm,
    33		     unsigned long vaddr)
    34	{
    35		return uprobe_write_opcode(mm, vaddr,
  > 36			   __opcode_to_mem_arm(uprobe->arch.bpinsn));
  > 37	}
    38	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28032 bytes)