linux-kernel - Re: [PATCH] crypto: testmgr: add test vectors for skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180620175638.GB76265@gmail.com>
Date:   Wed, 20 Jun 2018 10:56:38 -0700
From:   Eric Biggers <ebiggers3@...il.com>
To:     Juan Manuel Torres Palma <j.m.torrespalma@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        davem@...emloft.net, herbert@...dor.apana.org.au
Subject: Re: [PATCH] crypto: testmgr: add test vectors for skein

Hi Juan,

On Wed, Jun 20, 2018 at 07:57:14PM +0900, Juan Manuel Torres Palma wrote:
> Adds test vectors specified in skein v1.3
> specification. The main code is still in staging
> directory, but this is required to eventually be
> moved to the crypto directory.
> 
> Signed-off-by: Juan Manuel Torres Palma <j.m.torrespalma@...il.com>
> ---
>  crypto/testmgr.c |  21 ++++++
>  crypto/testmgr.h | 203 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 224 insertions(+)
> 
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 11e45352fd0b..9fa08cbc8852 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -3453,6 +3453,27 @@ static const struct alg_test_desc alg_test_descs[] = {
>  		.suite = {
>  			.hash = __VECS(sha512_tv_template)
>  		}
> +	}, {
> +		.alg = "skein1024",
> +		.test = alg_test_hash,
> +		.fips_allowed = 1,

Are you sure Skein should be on the "FIPS allowed" list?  I'm not particularly
familiar with FIPS, but my understanding is that the fips_allowed flag is only
supposed to be set on specific "approved" algorithms.  So if you're unsure, it
shouldn't be set.

Eric