linux-kernel - Re: [PATCHv4 08/18] atomics/generic: define atomic64_fetch_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180621122103.7k2ozjyc64b4zdjc@lakrids.cambridge.arm.com>
Date:   Thu, 21 Jun 2018 13:21:03 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     mingo@...nel.org, will.deacon@....com, peterz@...radead.org,
        linux-kernel@...r.kernel.org
Cc:     Boqun Feng <boqun.feng@...il.com>, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCHv4 08/18] atomics/generic: define
 atomic64_fetch_add_unless()

On Thu, Jun 21, 2018 at 01:13:11PM +0100, Mark Rutland wrote:
> -	if (v->counter != u) {
> +	val = v->counter;
> +	if (val != u)
>  		v->counter += a;
> -		ret = true;
>  	}

Ugh, I thought I had fixed this up and removed the trailing brace.

This will break some 32-bit arches as-is.

Ingo, would you be hapyp to fix this up, or would you prefer that I fix
and resend?

Sorry about this.

Mark.