linux-kernel - Re: [PATCHv4 08/18] atomics/generic: define atomic64_fetch_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180621122630.GA22578@gmail.com>
Date:   Thu, 21 Jun 2018 14:26:30 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     will.deacon@....com, peterz@...radead.org,
        linux-kernel@...r.kernel.org, Boqun Feng <boqun.feng@...il.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCHv4 08/18] atomics/generic: define
 atomic64_fetch_add_unless()


* Mark Rutland <mark.rutland@....com> wrote:

> On Thu, Jun 21, 2018 at 01:13:11PM +0100, Mark Rutland wrote:
> > -	if (v->counter != u) {
> > +	val = v->counter;
> > +	if (val != u)
> >  		v->counter += a;
> > -		ret = true;
> >  	}
> 
> Ugh, I thought I had fixed this up and removed the trailing brace.
> 
> This will break some 32-bit arches as-is.
> 
> Ingo, would you be hapyp to fix this up, or would you prefer that I fix
> and resend?

I fixed it up, no need to resend unless I find other problems in testing.

> Sorry about this.

No problem!

Thanks,

	Ingo