linux-kernel - Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <57f6e02e-a8e8-73fb-11d1-24fb6b5e2e9a@linux.ibm.com>
Date:   Fri, 22 Jun 2018 10:10:01 +0200
From:   Thomas-Mich Richter <tmricht@...ux.ibm.com>
To:     Andi Kleen <ak@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        acme@...nel.org, brueckner@...ux.vnet.ibm.com,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com
Subject: Re: [PATCH 4/4] perf stat: Add transaction flag (-T) support for s390

On 06/22/2018 04:36 AM, Andi Kleen wrote:
> Thomas Richter <tmricht@...ux.ibm.com> writes:
>>  
>> +		/* Handle -T as -M transaction. Once platform specific metrics
>> +		 * support has been added to the json files, all archiectures
>> +		 * will use this approach.
>> +		 */
>> +		if (!strcmp(perf_env__arch(NULL), "s390")) {
> 
> Use pmu_have_event() instead.

Done see version v2

> 
> You may need to add support for wildcard pmus to it.
> 
> -Andi
> 

Currently only one PMU on s390 does support transactions, its the PMU with counters
named cpum_cf.

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz 
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294