linux-kernel - Re: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1806240226370.8650@nanos.tec.linutronix.de>
Date:   Sun, 24 Jun 2018 02:28:49 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     David Howells <dhowells@...hat.com>
cc:     Reinette Chatre <reinette.chatre@...el.com>, fenghua.yu@...el.com,
        Tony Luck <tony.luck@...el.com>,
        vikas.shivappa@...ux.intel.com, gavin.hindman@...el.com,
        jithu.joseph@...el.com, dave.hansen@...el.com, mingo@...hat.com,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache
 Pseudo-Locking enabling

On Sun, 24 Jun 2018, David Howells wrote:

> Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> >  - Stick the struct into the local header file and not at some random place in
> >    the source.
> 
> Why?  It's only used in that one file.  There doesn't seem to be any
> particular need to share it around.

It's not in a global header. It's a local header exactly to stick stuff
like that into it.

> >  - Get rid of the fugly camel case
> 
> It's not camel case.  It's the name of the option it's encoding.  But if it
> makes you happy...

Well, the option name slipped through, but that doesn't make an excuse for
making the struct member equally ugly. 

Thanks,

	tglx