linux-kernel - Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize memory, instead of loop.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VegybTJJ8GruGORxB3NChgsEKN+kJF55UjU0OvP2svuQQ@mail.gmail.com>
Date:   Mon, 25 Jun 2018 12:06:30 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     John Whitmore <johnfwhitmore@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v3 3/8] staging: rtl8192u: User memset to initialize
 memory, instead of loop.

On Sun, Jun 24, 2018 at 6:34 PM, John Whitmore <johnfwhitmore@...il.com> wrote:
> Replaced memory initialising loop with memset, as suggested by Andy Shevchenko
>

Suggested-by ?

> Signed-off-by: John Whitmore <johnfwhitmore@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index 4bfadb49c363..ccb7bdf5ad5d 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -742,8 +742,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
>   */
>  static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
>  {
> -       u8                                      i;
> -
>         if (!pOperateMCS) {
>                 IEEE80211_DEBUG(IEEE80211_DL_ERR, "pOperateMCS can't be null in HT_PickMCSRate()\n");
>                 return false;
> @@ -756,8 +754,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
>                 //legacy rate routine handled at selectedrate
>
>                 //no MCS rate
> -               for (i = 0; i <= 15; i++)
> -                       pOperateMCS[i] = 0;
> +               memset(pOperateMCS, 0, 16);
>                 break;
>
>         case IEEE_N_24G:        //assume CCK rate ok
> --
> 2.17.1
>



-- 
With Best Regards,
Andy Shevchenko