linux-kernel - Re: [PATCH v3 7/8] staging: rtl8192u: Correct if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180625114617.l4uc7c6k3gxd5tks@xux707-tw>
Date:   Mon, 25 Jun 2018 12:46:18 +0100
From:   John Whitmore <arigead@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding
 Style

On Sun, Jun 24, 2018 at 08:59:22AM -0700, Joe Perches wrote:
> Rather than doing individual patches for each line
> with a whitespace issue, I think it'd be better to
> do a single driver wide patch.
> 
> Perhaps use a tool like:
> 
> $ git ls-files drivers/staging/rtl8192u |
>   xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing
> 
> where:
> 
> $ git diff -w drivers/staging/rtl8192u/
> 
> should not show a single difference.
> 
> Then compile and commit that as a single patch with
> something like "use a more typical spacing style"
> as the commit message.
> 

Thank you for that command. Hadn't found the "--types=spacing" option.

I'd fixed all the spacing issues in that file in a previous patch set. That
space issue was in a commented out section of code, which is why I missed it
previously. I think that file has all space issues cleared so there's only the
single fix in this patch.