linux-kernel - Re: [PATCH] objtool: Fix GCC 8 cold function processing without -freorder-functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180626194327.GP2494@hirez.programming.kicks-ass.net>
Date:   Tue, 26 Jun 2018 21:43:27 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     Allan Xavier <allan.x.xavier@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: Fix GCC 8 cold function processing without
 -freorder-functions

On Tue, Jun 26, 2018 at 01:44:05PM -0500, Josh Poimboeuf wrote:
> On Tue, Jun 26, 2018 at 07:31:18PM +0100, Allan Xavier wrote:

> > Is there a particular concern you're trying to address by having the logic there
> > instead?
> 
> Thanks for the patch and the excellent problem description.  I think the
> concern is that the overlap might cause other unforeseen issues (now or
> in the future).

Yeah, overlapping symbols are just really weird and unfortunate, I've no
idea what the GCC people were thinking.

Note how find_symbol_containing() already more or less assumed !overlap.