linux-kernel - Re: [PATCH] objtool: Fix GCC 8 cold function processing without -freorder-functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180626210709.i2x5qrpu7bf5xi2p@treble>
Date:   Tue, 26 Jun 2018 16:07:09 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Allan Xavier <allan.x.xavier@...cle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: Fix GCC 8 cold function processing without
 -freorder-functions

On Tue, Jun 26, 2018 at 09:43:27PM +0200, Peter Zijlstra wrote:
> On Tue, Jun 26, 2018 at 01:44:05PM -0500, Josh Poimboeuf wrote:
> > On Tue, Jun 26, 2018 at 07:31:18PM +0100, Allan Xavier wrote:
> 
> > > Is there a particular concern you're trying to address by having the logic there
> > > instead?
> > 
> > Thanks for the patch and the excellent problem description.  I think the
> > concern is that the overlap might cause other unforeseen issues (now or
> > in the future).
> 
> Yeah, overlapping symbols are just really weird and unfortunate, I've no
> idea what the GCC people were thinking.
> 
> Note how find_symbol_containing() already more or less assumed !overlap.

If there are no objections to my patch, I'll run it through 0-day
testing and post an official version tomorrow-ish if it doesn't break
anything.

-- 
Josh