linux-kernel - RE: [PATCH] ARM: dts: imx6sll-evk: enable usdhc3 slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM3PR04MB1315128EA1000FD6D0903CEAF54F0@AM3PR04MB1315.eurprd04.prod.outlook.com>
Date:   Thu, 28 Jun 2018 01:14:44 +0000
From:   Anson Huang <anson.huang@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, dl-linux-imx <linux-imx@....com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: dts: imx6sll-evk: enable usdhc3 slot

Hi, Fabio

Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@...il.com]
> Sent: Wednesday, June 27, 2018 10:31 PM
> To: Anson Huang <anson.huang@....com>
> Cc: Shawn Guo <shawnguo@...nel.org>; Sascha Hauer
> <s.hauer@...gutronix.de>; Sascha Hauer <kernel@...gutronix.de>; Fabio
> Estevam <fabio.estevam@....com>; Rob Herring <robh+dt@...nel.org>;
> Mark Rutland <mark.rutland@....com>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>;
> dl-linux-imx <linux-imx@....com>; moderated list:ARM/FREESCALE IMX / MXC
> ARM ARCHITECTURE <linux-arm-kernel@...ts.infradead.org>; linux-kernel
> <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH] ARM: dts: imx6sll-evk: enable usdhc3 slot
> 
> Hi Anson,
> 
> On Wed, Jun 27, 2018 at 5:36 AM, Anson Huang <Anson.Huang@....com>
> wrote:
> 
> > +&usdhc3 {
> > +       pinctrl-names = "default", "state_100mhz", "state_200mhz";
> > +       pinctrl-0 = <&pinctrl_usdhc3>;
> > +       pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> > +       pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> > +       cd-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
> > +       keep-power-in-suspend;
> > +       enable-sdio-wakeup;
> > +       vmmc-supply = <&reg_sd3_vmmc>;
> > +       status = "okay";
> > +};
> > +
> >  &usbotg1 {
> 
> Please keep the nodes sorted in alphabetical order.

Thanks, it is because original code does NOT do it in alphabetical order, so I just added
usdhc3 at the end of usdhc1, but I sent V2 patch to re-sort it anyway, please review it.  

Anson.