linux-kernel - Re: staging: rtl8723bs: bug or pointless if else ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Jun 2018 10:22:41 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Michael Straube <straube.linux@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     hadess@...ess.net, Larry.Finger@...inger.net,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: staging: rtl8723bs: bug or pointless if else ?

Hi,

On 28-06-18 09:43, Michael Straube wrote:
> Hi,
> 
> I stumbled upon the following if else construct in
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c:618
> 
>          if (pwrpriv->bInternalAutoSuspend)
>          {
>                  ret = rtw_resume_process(padapter);
>          }
>          else
>          {
>                  if (pwrpriv->wowlan_mode || pwrpriv->wowlan_ap_mode)
>                  {
>                          ret = rtw_resume_process(padapter);
>                  }
>                  else
>                  {
>                          ret = rtw_resume_process(padapter);
>                  }
>          }
> 
> It does not matter if the conditions are true or not,
> ret is always set to:
> 
> ret = rtw_resume_process(padapter)
> 
> Is this a bug or is the if else construct just pointless?

It probably is just pointless, my guess would be that once
upon a time there was a difference in the paths and at some
point that difference went away.

Regards,

Hans