linux-kernel - Re: [PATCH v2 2/3] printk: Create helper function to queue deferred console handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180628021944.GC481@jagdpanzerIV>
Date:   Thu, 28 Jun 2018 11:19:44 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 2/3] printk: Create helper function to queue deferred
 console handling

On (06/28/18 11:16), Sergey Senozhatsky wrote:
> 
> You can just call vprintk_emit(LOGLEVEL_SCHED) from vprintk_func(),
> then you don't need to factor out vprintk_deferred() and vprintk_emit().
> Any reason for that split?

My bad, no you can't. I forgot that for direct_nmi vprintk_func()
logbuf_lock is locked at the upper level - vprintk_func().

	-ss