linux-kernel - Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system configuration"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20180629192838.GE4799@rapoport-lnx>
Date:   Fri, 29 Jun 2018 22:28:38 +0300
From:   Mike Rapoport <rppt@...ux.vnet.ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Vineet Gupta <vgupta@...opsys.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arc/Kconfig: include mm/Kconfig inside "ARC system
 configuration"

Hi Randy, 

On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote:
> On 06/29/2018 06:42 AM, Mike Rapoport wrote:
> > Otherwise mm configuration options show up in the top level menu.
> > 
> > Signed-off-by: Mike Rapoport <rppt@...ux.vnet.ibm.com>
> 
> Hi Mike,
> 
> In which config tool does this matter?
> 
> For xconfig, it seems to me that this patch hides the MM menu, whereas
> before this patch, the MM menu is easy to find (although it could
> use some kind of heading).

With xconfig the menu gets into the top right pane when you click on "ARC
architecture configuration", similar to what one gets on x86 with
"Processor type and features" or "Kernel features" on ARM.

With menuconfig it looks a bit more prominent, note that mm options are
between "ARC Architecture Configuration" and "Networking support":

 .config - Linux/arc 4.18.0-rc2 Kernel Configuration
 ──────────────────────────────────────────────────────────────────────────────
  ┌─────────────── Linux/arc 4.18.0-rc2 Kernel Configuration ───────────────┐
  │  Arrow keys navigate the menu.  <Enter> selects submenus ---> (or empty │  
  │  submenus ----).  Highlighted letters are hotkeys.  Pressing <Y>        │  
  │  includes, <N> excludes, <M> modularizes features.  Press <Esc><Esc> to │  
  │  exit, <?> for Help, </> for Search.  Legend: [*] built-in  [ ]         │  
  │ ┌─────────────────────────────────────────────────────────────────────┐ │  
  │ │        *** Compiler: arc-elf-gcc (GCC) 7.3.0 ***                    │ │  
  │ │        General setup  --->                                          │ │  
  │ │    [*] Enable loadable module support  --->                         │ │  
  │ │    [*] Enable the block layer  --->                                 │ │  
  │ │        ARC Architecture Configuration  --->                         │ │  
  │ │    [ ] Allow for memory compaction                                  │ │  
  │ │    [*] Enable bounce buffers                                        │ │  
  │ │    [ ] Enable KSM for page merging                                  │ │  
  │ │    (4096) Low address space to protect from user allocation         │ │  
  │ │    [ ] Enable cleancache driver to cache clean pages if tmem is pres│ │  
  │ │    [ ] Contiguous Memory Allocator                                  │ │  
  │ │    < > Common API for compressed memory storage                     │ │  
  │ │    < > Low (Up to 2x) density storage for compressed pages          │ │  
  │ │    < > Memory allocator for compressed pages                        │ │  
  │ │    [ ] Enable idle page tracking                                    │ │  
  │ │    [ ] Collect percpu memory statistics                             │ │  
  │ │    [ ] Enable infrastructure for get_user_pages_fast() benchmarking │ │  
  │ │    (11) Maximum zone order                                          │ │  
  │ │    [*] Networking support  --->                                     │ │  
  │ │        Device Drivers  --->                                         │ │  
  │ │        Bus Support  --->                                            │ │  
  │ │        File systems  --->                                           │ │  
  │ │        Kernel hacking  --->                                         │ │  
  │ │        Security options  --->                                       │ │  
  │ │    -*- Cryptographic API  --->                                      │ │  
  │ │        Library routines  --->                                       │ │  
  │ │    [ ] Device power management core functionality                   │ │  
  │ │                                                                     │ │  
  │ └─────────────────────────────────────────────────────────────────────┘ │  
  ├─────────────────────────────────────────────────────────────────────────┤  
  │        <Select>    < Exit >    < Help >    < Save >    < Load >         │  
  └─────────────────────────────────────────────────────────────────────────┘  
    



> >  	default "12" if ARC_HUGEPAGE_16M
> >  	default "11"
> >  
> > +endmenu	 # "ARC Architecture Configuration"
> > +
> >  source "net/Kconfig"
> >  source "drivers/Kconfig"
> >  
> > 
> 
> 
> -- 
> ~Randy
> 

-- 
Sincerely yours,
Mike.