linux-kernel - Re: [PATCH] staging: rtl8723bs: fix comparsion to true/false and brace issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f150191b-3458-75d0-e338-f609503b177a@gmail.com>
Date:   Sat, 30 Jun 2018 12:52:40 +0200
From:   Michael Straube <straube.linux@...il.com>
To:     Andreas Schwab <schwab@...ux-m68k.org>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix comparsion to true/false and
 brace issues

On 06/30/18 12:08, Andreas Schwab wrote:
> On Jun 30 2018, Michael Straube <straube.linux@...il.com> wrote:
> 
>> @@ -115,11 +115,10 @@ s32 rtw_btcoex_IsBTCoexCtrlAMPDUSize(struct adapter *padapter)
>>   
>>   void rtw_btcoex_SetManualControl(struct adapter *padapter, u8 manual)
>>   {
>> -	if (true == manual) {
>> +	if (manual)
>>   		hal_btcoex_SetManualControl(padapter, true);
>> -	} else{
>> +	else
>>   		hal_btcoex_SetManualControl(padapter, false);
>> -	}
> 
> aka. hal_btcoex_SetManualControl(padapter, manual);
> 
> Andreas.
> 

Ah, thanks!

Michael