linux-kernel - [PATCH v2] thermal: i.MX: Allow thermal probe to fail gracefully in case of bad calibration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20180630221050.1474-1-jcd@tribudubois.net>
Date:   Sun,  1 Jul 2018 00:10:50 +0200
From:   Jean-Christophe Dubois <jcd@...budubois.net>
To:     shawnguo@...nel.org, kernel@...gutronix.de, linux-imx@....com,
        linux-arm-kernel@...ts.infradead.org, rui.zhang@...el.com,
        edubezval@...il.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Jean-Christophe Dubois <jcd@...budubois.net>
Subject: [PATCH v2] thermal: i.MX: Allow thermal probe to fail gracefully in case of bad calibration.

Without this fix, the thermal probe on i.MX6 might trigger a division
by zero exception later in the probe if the calibration does fail.

Note: This linux behavior (Division by zero in kernel) has been triggered
on a Qemu i.MX6 emulation where parameters in nvmem were not set. With this
fix the division by zero is not triggeed anymore as the thermal probe does
fail early.

Signed-off-by: Jean-Christophe Dubois <jcd@...budubois.net>
Reviewed-by: Fabio Estevam <fabio.estevam@....com>
---
v2 changes:
 - improved subject line
 - added thermal maintainers in the destination list.

 drivers/thermal/imx_thermal.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c
index 334d98be03b9..b1f82d64253e 100644
--- a/drivers/thermal/imx_thermal.c
+++ b/drivers/thermal/imx_thermal.c
@@ -604,7 +604,10 @@ static int imx_init_from_nvmem_cells(struct platform_device *pdev)
 	ret = nvmem_cell_read_u32(&pdev->dev, "calib", &val);
 	if (ret)
 		return ret;
-	imx_init_calib(pdev, val);
+
+	ret = imx_init_calib(pdev, val);
+	if (ret)
+		return ret;
 
 	ret = nvmem_cell_read_u32(&pdev->dev, "temp_grade", &val);
 	if (ret)
-- 
2.17.1