linux-kernel - Re: [PATCH] i2c: designware-pcidrv: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f9e75b62b5e93b28694e6dac2abf0a398ee3dc1.camel@linux.intel.com>
Date:   Tue, 03 Jul 2018 22:16:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware-pcidrv: Mark expected switch
 fall-through

On Tue, 2018-07-03 at 14:10 -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> 
> where we are expecting to fall through.

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/i2c/busses/i2c-designware-pcidrv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-designware-pcidrv.c
> b/drivers/i2c/busses/i2c-designware-pcidrv.c
> index 86e1bd0..b4997be 100644
> --- a/drivers/i2c/busses/i2c-designware-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-designware-pcidrv.c
> @@ -105,6 +105,7 @@ static int mfld_setup(struct pci_dev *pdev, struct
> dw_pci_controller *c)
>  	case 0x0817:
>  		c->bus_cfg &= ~DW_IC_CON_SPEED_MASK;
>  		c->bus_cfg |= DW_IC_CON_SPEED_STD;
> +		/* fall through */
>  	case 0x0818:
>  	case 0x0819:
>  		c->bus_num = pdev->device - 0x817 + 3;

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy