linux-kernel - Re: [PATCH v3 1/2] powernv/cpuidle: Parse dt idle properties into global structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180703094636.GA24693@in.ibm.com>
Date:   Tue, 3 Jul 2018 15:16:36 +0530
From:   Gautham R Shenoy <ego@...ux.vnet.ibm.com>
To:     Akshay Adiga <akshay.adiga@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-pm@...r.kernel.org, rjw@...ysocki.net,
        stewart@...ux.vnet.ibm.com, benh@...nel.crashing.org,
        svaidy@...ux.vnet.ibm.com, ego@...ux.vnet.ibm.com,
        npiggin@...il.com, mpe@...erman.id.au
Subject: Re: [PATCH v3 1/2] powernv/cpuidle: Parse dt idle properties into
 global structure

Hi Akshay,

On Tue, Jul 03, 2018 at 02:50:55PM +0530, Akshay Adiga wrote:
> Device-tree parsing happens twice, once while deciding idle state to be
> used for hotplug and once during cpuidle init. Hence, parsing the device
> tree and caching it will reduce code duplication. Parsing code has been
> moved to pnv_parse_cpuidle_dt() from pnv_probe_idle_states(). In addition
> to the properties in the device tree the number of available states is
> also required.
> 
> Signed-off-by: Akshay Adiga <akshay.adiga@...ux.vnet.ibm.com>
> Reviewed-by: Nicholas Piggin <npiggin@...il.com>

Looks good.
Reviewed-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>