linux-kernel - Re: [PATCH v3 2/2] powernv/cpuidle: Use parsed device tree values for cpuidle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 3 Jul 2018 15:17:59 +0530
From:   Gautham R Shenoy <ego@...ux.vnet.ibm.com>
To:     Akshay Adiga <akshay.adiga@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-pm@...r.kernel.org, rjw@...ysocki.net,
        stewart@...ux.vnet.ibm.com, benh@...nel.crashing.org,
        svaidy@...ux.vnet.ibm.com, ego@...ux.vnet.ibm.com,
        npiggin@...il.com, mpe@...erman.id.au
Subject: Re: [PATCH v3 2/2] powernv/cpuidle: Use parsed device tree values
 for cpuidle_init

Hi Akshay,

On Tue, Jul 03, 2018 at 02:50:56PM +0530, Akshay Adiga wrote:
> Export pnv_idle_states and nr_pnv_idle_states so that its accessible to
> cpuidle driver. Use properties from pnv_idle_states structure for powernv
> cpuidle_init.
> 
> Signed-off-by: Akshay Adiga <akshay.adiga@...ux.vnet.ibm.com>
> Reviewed-by: Nicholas Piggin <npiggin@...il.com>
> ---

[..snip..]

> 
>  		/*
>  		 * For nap and fastsleep, use default target_residency
>  		 * values if f/w does not expose it.
>  		 */

This comment can also go, since we are no longer hard-coding the
residency values in the kernel.

Otherwise looks good to me.

Reviewed-by: Gautham R. Shenoy <ego@...ux.vnet.ibm.com>


--
Thanks and Regards
gautham.