linux-kernel - Re: [PATCH 2/2] misc: sram: enable clock before registering regions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180703114703.GO9802@localhost>
Date:   Tue, 3 Jul 2018 13:47:03 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] misc: sram: enable clock before registering regions

On Tue, Jul 03, 2018 at 01:23:30PM +0300, Vladimir Zapolskiy wrote:
> Hi Johan,
> 
> On 07/03/2018 01:05 PM, Johan Hovold wrote:
> > Make sure to enable the clock before registering regions and exporting
> > partitions to user space at which point we must be prepared for I/O.
> > 
> > Fixes: ee895ccdf776 ("misc: sram: fix enabled clock leak on error path")
> > Cc: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
> > Signed-off-by: Johan Hovold <johan@...nel.org>
> 
> thank you for the change, however please note that the identified commit
> for the fix is incorrect one apparently.
> 
> In my opinion the proper tag contents would be
> 
> Fixes: b4c3fcb3c71f ("misc: sram: extend usage of reserved partitions")
> 
> I hope you agree to it, also I would suggest to swap the changes in
> the series.

No, I think I used the right commit in the Fixes tag as that was the
commit which moved the clock enable to after the memory-region
registration (at which point the memory could potentially be accessed).

Johan